facebook/stetho

Implement checkstyle for travis-CI code style checks

Open

#239 opened on Jul 31, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (1,163 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (12,643 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Now that the number of PRs is starting to heat up, it's time to enforce some of the basic style rules of the project using CI. checkstyle seems like a mature and reasonable way to do that, though I'm open to suggestions :)

Contributor guide

Research direction
Start by reading the project's build system (Gradle) and CI configuration (Travis). Create a checkstyle configuration file (e.g., checkstyle.xml) that enforces basic style rules from the project's coding standards. Then, add a Gradle task for checkstyle and integrate it into the Travis CI configuration to run on pull requests.
Tech stack
java
Domain
build systemci cd
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaGradle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75