facebook/stetho

Implement checkstyle for travis-CI code style checks

Open

#239 opened on Jul 31, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (12,643 stars) (1,163 forks)batch import
enhancementhelp wanted

Description

Now that the number of PRs is starting to heat up, it's time to enforce some of the basic style rules of the project using CI. checkstyle seems like a mature and reasonable way to do that, though I'm open to suggestions :)

Contributor guide

Tech stack
java
Domain
ci cdtooling
Issue type
devops
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java development basicsTravis CI usageCheckstyle configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Begin by examining the current repository's CI configuration in the `.travis.yml` file to understand existing build steps. Then, research checkstyle's Maven/Gradle plugin to integrate style checks into the build. Create a `checkstyle.xml` configuration file with the project's coding standards. Finally, update `.travis.yml` to run checkstyle checks after the build.