facebook/sapling

[ISL][Feature Request] Specify github reviewers

Open

#679 opened on Jul 19, 2023

View on GitHub
 (2 comments) (3 reactions) (0 assignees)Rust (4,649 stars) (182 forks)batch import
help wantedisl

Description

Currently whenever creating a PR with sapling, I still need to open the PR in github to finish off some things. It would be much more ideal if I could be done after clicking "Submit". One such thing is specifying reviewers for the PR (which seems to be supported internally).

It seems like there's already support for something like this by adding to OSSDefaultFieldSchema and using the type: 'field'. Autocomplete could be easily implemented via github graphql API. My main concern is how to actually pass the information from ISL webview to lower level APIs (not very familiar with that), and vice-versa for PRs with reviewers. It seems like there's an assumption that commit description has all this metadata stored as text which seems weird for github PRs. If there's any quick pointers here I'd be happy to tackle this, but might be a bit complex.

Contributor guide

Tech stack
rusttypescriptgraphql
Domain
full stackdeveloper experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of RustUnderstanding of TypeScriptFamiliarity with GraphQLExperience with webview and backend communication
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Start by examining OSSDefaultFieldSchema in the ISL codebase (likely in `isl/src/`). Understand how commit metadata is passed between the webview and backend. Explore existing field types and how they interact with GitHub's GraphQL API for autocomplete. Review the internal implementation for reviewers mentioned in the issue. Consider adding a new field type and mapping it to PR metadata when submitting.