facebook/sapling

Patch export

Open

#318 opened on Dec 11, 2022

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Rust (4,649 stars) (182 forks)batch import
enhancementgood-first-issuehelp wanted

Description

It would be nice if we had the ability to export commits under the Git email .patch (example: https://patch-diff.githubusercontent.com/raw/facebook/sapling/pull/287.patch)

I use the mailing list patch workflow for some personal projects and would love to use sl to manage the repo, but exporting diffs to mail is a bit difficult right now.

sl export exists, but it's descended from hg export and does not have all the information the Git patch format does (From lines, date, Subject lines, diffstat, unified file diffs)

Contributor guide

Tech stack
rust
Domain
clitooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingSapling codebase familiarityGit patch format
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the current `sl export` implementation in Sapling's codebase, likely in Rust files under `lib/` or commands. Understand the Git patch format (RFC 2822) and how to generate 'From', 'Date', 'Subject' lines, diffstat, and unified diffs. Review comments in the issue for community suggestions. Consider adding a new flag or command to produce Git style patches.