facebook/relay

Expand PluginInterface support

Open

#2647 opened on Feb 18, 2019

View on GitHub
 (8 comments) (3 reactions) (0 assignees)Rust (18,930 stars) (1,874 forks)batch import
enhancementhelp wantedwontfix

Description

I just wrote a plugin for scalajs (very rough but works), using the plugin interface and two things would be super nice to support.

  • Extra schema, like in the relayCompilerBin you add directives, it would be nice for a plugin to be able to add custom directives.
  • The getFileFilter function looks for the string graphql, we should be able to override that.

Otherwise, it went well.

Contributor guide

Tech stack
graphqljavascripttypescriptrust
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Relay compilerBasic knowledge of RustGraphQL schema definition
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the existing PluginInterface in the Relay compiler, specifically the `relayCompilerBin` and `getFileFilter` functions. Look for how custom directives could be added via a plugin hook. Consider adding a method for plugins to define custom directives and a way to override the default file filter. Check the issue comments for any proposed implementation ideas.