facebook/relay

Relax constraint of unique file names in Relay Modern

Open

#2093 opened on Sep 11, 2017

View on GitHub
 (5 comments) (22 reactions) (0 assignees)Rust (18,930 stars) (1,874 forks)batch import
help wanted

Description

Relay Classic / Compat require file names to match fragment names to ensure Relay Compat mechanisms work correctly. However in Relay Modern this doesn't necessarily need to be true.

There have been a few issues opened in the past about this issue, so it would be great to fix this with a pull request.

Note that fragment names should still continue to be unique across a compiled app.

Contributor guide

Tech stack
javascriptreactgraphql
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Relay Modern internalsGraphQL fragment namingJavaScriptRelay compiler knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the Relay compiler source code to locate where unique file names are enforced. Look for validation logic in the build step. Consider removing the check for Modern mode while preserving it for Compat. Ensure fragment name uniqueness across the app is maintained. Review linked issues and comments for additional context.