facebook/prophet

Clarify Valid Unit Types if Unit Type is Unrecognized

Open

#1,989 opened on Aug 8, 2021

View on GitHub
 (2 comments) (2 reactions) (0 assignees)Python (17,686 stars) (4,451 forks)batch import
enhancementgood first issue

Description

I'm trying to use prophet cross_validation but I received a value error for unrecognized type when I try:

df_cv = cross_validation(m, initial='120 months', period='12 months', horizon = '12 months')

I think the error should return a list of valid types so that I don't have to go look up why months aren't recognized as a valid unit.

Contributor guide

Tech stack
python
Domain
developer experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonProphet library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Locate the cross validation function in the Prophet codebase, likely in prophet/diagnostics.py. Find where unit types are validated and the error is raised. Modify the error message to include a list of valid unit types (e.g., 's', 'sec', 'min', 'hour', 'day', etc.). Ensure consistency with other similar validation error messages in the code.
Clarify Valid Unit Types if Unit Type is Unrecognized · facebook/prophet#1989 | Good First Issue