facebook/prop-types

`oneOfType()` does not seem to allow all types specified

Open

#388 opened on Oct 20, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (4,379 stars) (389 forks)batch import
bughelp wanted

Description

I am running into an issue where oneOfType() is passed in types of shape and string but is only allowing string seemingly.

Reproduced here (using a simplified version of types I have encountered on a project I am working on), https://jsfiddle.net/liamness/1du5jvwt/, with the warning:

Failed prop type: Invalid prop `schema[1]` supplied to `ComponentName`, expected one of type [string].

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptReact prop types
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the implementation of oneOfType in the prop types source code (likely in src/index.js or similar). Use the provided JSFiddle reproduction to understand the issue: when passing a shape and string type, only string is validated. Look for how oneOfType iterates over types and checks validity. Check if there is a bug in the type checking loop that causes early exit or incorrect validation. Consider submitting a fix that ensures all specified types are properly validated.