facebook/prop-types

`oneOfType()` does not seem to allow all types specified

Open

#388 opened on Oct 20, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (389 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,379 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I am running into an issue where oneOfType() is passed in types of shape and string but is only allowing string seemingly.

Reproduced here (using a simplified version of types I have encountered on a project I am working on), https://jsfiddle.net/liamness/1du5jvwt/, with the warning:

Failed prop type: Invalid prop `schema[1]` supplied to `ComponentName`, expected one of type [string].

Contributor guide

Research direction
Examine the `oneOfType` implementation in prop types, trace the validation logic to see why it only accepts the first type in the array. Investigate the jsfiddle reproduction to confirm the behavior and then check for any missing type checks or early returns.
Tech stack
javascriptreact
Domain
frontenddeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75