facebook/prop-types

Return value from checkPropTypes?

Open

#169 opened on Mar 1, 2018

View on GitHub
 (6 comments) (31 reactions) (0 assignees)JavaScript (389 forks)batch import
help wanted

Repository metrics

Stars
 (4,379 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is there a good reason not to return false if checkPropTypes fails any of the validations? I can't think of one myself. If no one disagrees I can do a PR.

This would be useful for those of us that want to use checkPropTypes for our own validation needs outside of React.

Contributor guide

Research direction
Examine the checkPropTypes function to understand current return behavior and modify it to return false when validation fails.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90