facebook/prop-types

React Portals can't be validated with prop-types

Open

#167 opened on Mar 1, 2018

View on GitHub
 (4 comments) (17 reactions) (0 assignees)JavaScript (389 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,379 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

PropTypes.node is not accepting element, created by React.createPortal as valid

Is it possible to treat element created by React.createPortal as iterator over it's children or treat portal itself as valid node?

Contributor guide

Research direction
Inspect the prop types implementation for PropTypes.node validation and check whether it handles React portal elements. Look at the source code of prop types to see how node types are validated and identify where portal elements fall through.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75