facebook/prop-types

React Portals can't be validated with prop-types

Open

#167 opened on Mar 1, 2018

View on GitHub
 (4 comments) (17 reactions) (0 assignees)JavaScript (4,379 stars) (389 forks)batch import
bughelp wanted

Description

PropTypes.node is not accepting element, created by React.createPortal as valid

Is it possible to treat element created by React.createPortal as iterator over it's children or treat portal itself as valid node?

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactUnderstanding of React PortalsFamiliarity with prop types API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the PropTypes.node implementation in the prop types library, specifically the isNode validator. Examine how React Portals are represented (as objects with a $$typeof). Determine if the validator can be extended to treat portals as valid nodes. Consider referencing the React source for createPortal.