facebook/lexical

better support for keyboard accessibility

Open

#6006 opened on May 2, 2024

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (16,523 stars) (1,349 forks)batch import
contribution-weekenhancementgood first issue

Description

In general using "Enter" on a toolbar that makes changes to lexical is problematic.

Lets say I have a button that toggles "bold" and it's triggered using the "Enter" key on the mouse-down event which calls dispatchCommand(FORMAT_TEXT_COMMAND...) - this causes lexical to get focus and then handle the Enter key which can replace the selected text with a new line.

adding the e.preventDefault to the event solves this problem but the focus still moves from the toolbar to the editor.

I'm not sure how to handle this...

Contributor guide

Tech stack
javascript
Domain
accessibilityfrontend
Issue type
accessibility
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
JavaScriptevent handlingaccessibility principles
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate focus management in Lexical's toolbar components. Examine the use of dispatchCommand and how Enter key events propagate. Consider implementing a pattern that prevents default on toolbar buttons to avoid unwanted editor interaction while maintaining keyboard accessibility. Look at existing accessibility documentation or issues for similar patterns. Review comments on issue #6006 for community suggestions.