facebook/lexical

Feature: support empty line in markdown

Open

#4838 opened on Jul 28, 2023

View on GitHub
 (4 comments) (2 reactions) (0 assignees)JavaScript (16,523 stars) (1,349 forks)batch import
contribution-weekenhancementgood first issuemarkdown

Description

In https://playground.lexical.dev/ if you enter multiple line breaks and toggle markdown twice. The empty lines will be eaten.

I checked the code https://github.com/facebook/lexical/blob/main/packages/lexical-markdown/src/MarkdownImport.ts#L80-L81 and I guess it's not implemented?

Contributor guide

Tech stack
javascripttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic JavaScriptLexical markdown plugin basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue is in MarkdownImport.ts at lines 80-81 where empty lines are not handled. Investigate how the markdown import parser currently processes line breaks and why empty lines are being eaten. Check the markdown export logic in MarkdownExport.ts for consistency. The solution likely involves adding support for empty lines in the import regex or parsing logic to preserve them as separate paragraphs.