facebook/fresco

Memory cache keeps growing when using non-static images in Recyclerview

Open

#2,502 opened on May 19, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Java (17,072 stars) (3,750 forks)batch import
enhancementgood first issuehelp wanted

Description

Description

I'm using lots of .webp images in my Recyclerview. And if I keep scrolling the Recyclerview, the native memory keeps growing until it reaches the maximum memory cache limit. I've also tested with the demo by jumping between fragments which has .webp images in it, still the native memory grows to the limit. It looks like Fresco will create a new cache for the same image every time the image got loaded.

I've already tried several ways, like reduce the memory cache limit or clear memory cache every time I leave the page. but these solutions can't solve the problem without affecting user's experience. Is there any way to fix or avoid this problem?

Reproduction

Any app that is using Fresco to load non-static images should be able to reproduce this problem.

Additional Information

Using .gif format has the same problem.

  • Fresco version: [2.2.0]
  • Platform version: [Android 9 / 10] (I've only tested with these two version)

Contributor guide

Tech stack
javaandroid
Domain
mobileperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android development knowledgeRecyclerView usageFresco basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate Fresco's memory cache behavior for non static images (e.g., animated .webp and .gif). Look at ImagePipeline and MemoryCache configuration, particularly how cache keys are generated for animated images. Check if cache entries are being duplicated or not evicted properly. Review related classes like `CountingMemoryCache`, `InstrumentedMemoryCache`, and `ImageCacheStatsTracker`. Also consider verifying the issue with the latest Fresco version, as the reported version is 2.2.0 and there may be subsequent fixes.
Memory cache keeps growing when using non-static images in Recyclerview · facebook/fresco#2502 | Good First Issue