facebook/fresco

SvgDecoderExample limit <svg tag

Open

#2,490 opened on Apr 20, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (17,072 stars) (3,750 forks)batch import
enhancementgood first issuehelp wanted

Description

We use GitHub Issues for bugs.

If you have a non-bug question, please ask on Stack Overflow: http://stackoverflow.com/questions/tagged/fresco

--- Please use this template, and delete everything above this line before submitting your issue ---

Description

I want use SimpleDraweeView to .setImageURI(Uri.parse("https://www.ups.com/assets/resources/images/UPS_logo.svg")); but the svg file is start with <?xml tag, so SvgDecoderExample.SvgFormatChecker() is block it.

Solution

I try update SvgDecoderExample.java line 33 : private static final String HEADER_TAG = "<svg"; to private static final String HEADER_TAG = "<?xml"; let it thought the cheker, it is visible now.
why you want to block the tag?
The AndroidSVG('com.caverock:androidsvg:1.2.1') lib is work find.

Additional Information

  • Fresco version: 'com.facebook.fresco:fresco:2.0.0'

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaAndroid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue is in SvgDecoderExample.java on line 33 where the constant HEADER TAG checks only for '<svg'. The reporter suggests changing it to '<?xml' or accepting both. The maintainer should confirm if files starting with <?xml are valid SVG and whether the fix should allow both patterns. Check the AndroidSVG library documentation for supported SVG root tags.