facebook/fresco

targetSdk 29 (scoped storage) support?

Open

#2,455 opened on Jan 10, 2020

View on GitHub
 (16 comments) (2 reactions) (1 assignee)Java (17,072 stars) (3,750 forks)batch import
enhancementgood first issuehelp wanted

Description

Description

Fresco failed to load images from EXTERNAL_CONTENT_URI e.g. content://media/external/images/media/8039, FileNotFoundException was seen from the logs

Reproduction

Loading images with EXTERNAL_CONTENT_URI content://media/external/images/media/8039

Solution

I found that inside com.facebook.imagepipeline.producers.LocalContentUriFetchProducer, given the above content uri, it will fall to the call getCameraImage and which in turn getting the absolute file path of the image. However, due to scoped storage in targetSdk 29, that wouldn't be allowed. Probably getting input stream like

ParcelFileDescriptor pfd = mContentResolver.openFileDescriptor(contentUri, "r");
FileInputStream fis = FileInputStream(pfd.getFileDescriptor());

Additional Information

  • Fresco version: 2.0.0
  • Platform version: Android 10

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android developmentContentResolver usageFresco image pipeline basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue is in `LocalContentUriFetchProducer.java`. The current implementation uses `getCameraImage` which fails on Android 10+ due to scoped storage. The solution involves using `ContentResolver.openFileDescriptor` to get a `ParcelFileDescriptor` and then a `FileInputStream`. The issue has an assignee, so check if they have made progress or if the fix is pending review. Also review the discussion comments for any additional context or alternative approaches.