facebook/fresco

I am testing the new features of Android P and found that the footprint of fresco displayed on Android P has been deformed.

Open

#2,192 opened on Aug 22, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (17,072 stars) (3,750 forks)batch import
buggood first issue

Description

Description

I am testing the new features of Android P and found that the footprint of fresco displayed on Android P has been deformed.

Reproduction <com.facebook.drawee.view.SimpleDraweeView android:id="@+id/iv_avatar" android:layout_width="60dp" android:layout_height="60dp" android:layout_alignParentLeft="true" android:layout_alignParentStart="true" android:layout_centerVertical="true" android:layout_marginLeft="20dp" android:layout_marginStart="20dp" android:scaleType="centerCrop" fresco:failureImage="@drawable/ic_head" fresco:placeholderImage="@drawable/ic_head" fresco:roundAsCircle="true"/>

Solution

I hope that you can provide a solution that will make the image appear on Android P the same as the previous version. Additional Information

  • Fresco version:1.10.0
  • Platform version: 28

image image

Contributor guide

Tech stack
java
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android developmentFresco basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate Android P rendering changes that affect rounded images in Fresco. Review the file SimpleDraweeView.java and the rounding logic in Fresco's drawing pipeline. Compare behavior on Android P vs older versions. Check issue comments for any maintainer hints. The screenshots show deformation of circular avatar, likely due to changes in BitmapShader or Canvas clipping in Android P. Look at commit history for any related fixes after this report.