facebook/fresco

Tell Fresco to use disk cache for thumbnails of local videos

Open

#2,171 opened on Aug 3, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (3,750 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (17,072 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

I'm using version 1.10.0

  • In root application, I call Fresco.initialize(getApplicationContext()).
  • In other UI controls, I pass Uri.fromFile("file://.../sdcard/example-video.mp4") to SimpleDraweeView. The view generates in-memory thumbnail and displays it correctly.
  • I check /data/data/my.app.id/cache/image_cache/ in emulator, no files or directories are in there. Which means for local videos, Fresco does not use disk cache.

Additional Information

  • Fresco version: 1.10.0
  • Platform version: emulator API 23

May I ask if you could consider adding option to tell Fresco to use disk cache for local videos? Normally generating thumbnails takes time, like 1-2 seconds per video (on my real device). So disk cache would help a lot.

Thank you,

====================

P.S: If someone could tell me how to do this hack then it would also help a lot:

Would it be possible to force Fresco to flush the in-memory generated thumbnails to disk cache? Then next time it checks for cache, it can use the cached files.

Contributor guide

Research direction
Examine Fresco's caching system (ImagePipeline, DiskCache) and the video thumbnail generation code. Identify where thumbnails are generated in memory and add a disk caching mechanism for them, considering the existing cache key generation for local videos.
Tech stack
javaandroid
Domain
mobile dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaAndroidGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65