facebook/fresco

Wide color gamut support for Postprocessors

Open

#2,103 opened on Apr 25, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (17,072 stars) (3,750 forks)batch import
enhancementhelp wanted

Description

Description

I want to load facebook logo image with fresco but when I am setting post processor, image not showing, looking to source code tells that fresco can not handle 16 bit png images, but this only happens when using post processor.

Reproduction

SimpleDraweeView image = findViewById(R.id.YOUR_SIMPLE_DRAWEE_VIEW);
String url = "https://www.facebook.com/images/fb_icon_325x325.png";

ImageRequest imageRequest = ImageRequestBuilder.newBuilderWithSource(Uri.parse(url))
        .setPostprocessor(new RoundAsCirclePostprocessor())
        .build();

PipelineDraweeController controller = (PipelineDraweeController) Fresco.newDraweeControllerBuilder()
        .setImageRequest(imageRequest)
        .setOldController(image.getController())
        .build();

image.setController(controller);

Additional Information

  • Fresco version: 1.9.0
  • Platform version: Android 8.0, One plus 5T

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android development experienceFamiliarity with Fresco libraryUnderstanding of PNG image formats
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
The issue is that 16 bit PNG images fail to display when a postprocessor is applied in Fresco. Investigate how Fresco decodes images and configures Bitmap objects (e.g., Bitmap.Config). Look at the ImageRequest and Postprocessor interfaces to see if the bitmap configuration is preserved. The fix may involve preserving the original color space or using Bitmap.Config.RGBA F16 for wide color gamut support. Check the Fresco source code for relevant classes like `DecodeImageRequest` and `Postprocessor`.