facebook/fresco

Color spaces in Android O are not handled properly by some features

Open

#1871 opened on Aug 20, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (17,072 stars) (3,750 forks)batch import
enhancementgood first issuehelp wanted

Description

Description

O is the first Android release that introduces a proper color management system into the OS and platform framework. This addition doesn't require any changes for simple decoding and displaying of Bitmaps, but some of Fresco's more advanced features seem to drop ColorSpace information.

I went through the Fresco Showcase sample app modified as described below and found bad color reproduction in these parts of the app:

  • Drawee -> Rotation
  • Image Pipeline -> Post-Processor
  • Image Pipeline -> Resizing

Things that I've not tested yet:

  • Progressive JPEGs,
  • GIFs
  • WebPs
  • SVGs
  • Images from Data URIs

Reproduction

  • Check out 3194ad2
  • Add whacked_jpg and whacked_png to res/drawable-nodpi in the Showcase module
    • I created these files from this image by using the "Match to Profile" feature of the macOS ColorSync Utility app with the popular WhackedRGB.icc and intent set to "Automatic".
  • Replace jpg urls with "res:///" + R.drawable.whacked_jpg and png urls with "res:///" + R.drawable.whacked_png in ImageUriProvider
  • Play around with the samples

Additional Information

  • Fresco version: 3194ad2
  • Platform version: Android O (rev. 5 of the emulator image)

Contributor guide

Tech stack
java
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android development experienceBasic knowledge of color spacesFamiliarity with Fresco's image pipeline
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the code paths for rotation, post processing, and resizing in Fresco's image pipeline to identify where ColorSpace information is dropped. Focus on classes related to Bitmap processing and ensure that ColorSpace is preserved. The issue provides reproduction steps using whacked images with embedded color profiles. Start by examining the post processor and resizing implementations, as those are documented to drop color space information. No existing PRs or maintainer guidance found.