facebook/flow

Cannot resolve JSON file starting with a dot

Open

#7673 opened on Apr 26, 2019

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Rust (22,203 stars) (1,885 forks)batch import
Has PRbuggood first issuemodule resolution

Description

Flow version:

version 0.97.0

Flow cannot resolve require with JSON filename starting with a dot:

const meta = require('../.meta.json');

It results in this error:

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/apps/graphql-skymock/datasets/__tests__/MetafileConsistency.test.js:7:22

Cannot resolve module ../.meta.json.

      4│ import path from 'path';
      5│ import Ajv from 'ajv';
      6│
      7│ const meta = require('../.meta.json');
      8│
      9│ test('every dataset defined in metafile should exist', () => {
     10│   expect.hasAssertions();

However, when I remove the dot (and rename the file) everything is fine:

const meta = require('../meta.json');

No errors!

Thank you very much for checking it! :)

Contributor guide

Tech stack
javascriptnodejs
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Flowmodule resolution conceptsNode.js require mechanism
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look at the module resolution logic in Flow's Rust source code, specifically how file paths are handled. Check if there is special handling for hidden files (dotfiles). The fix may involve updating the resolution algorithm to allow require paths starting with a dot file.