facebook/flipper

Discussion: add "Delete row" option for Database plugin

Open

#1370 opened on Jul 13, 2020

View on GitHub
 (12 comments) (0 reactions) (1 assignee)TypeScript (13,028 stars) (972 forks)batch import
enhancementgood first issueplugin-databases

Description

There is no "Delete row" button in Database plugin, only Edit. I think it should be pretty convenient to have an option for row deletion.

Contributor guide

Tech stack
typescript
Domain
desktopdatabase
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React basicsFlipper plugin architectureTypeScript fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Locate the Database plugin's UI component responsible for the row context menu. Find where the Edit button is rendered and copy its structure to add a Delete button. Connect the button to a database delete query function. Ensure the deletion is confirmed before execution. Review the issue comments for any additional requirements or UI mockups.