facebook/duckling

Support intervals for Numeral and Ordinal

Open

#352 opened on Mar 20, 2019

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Haskell (4,282 stars) (737 forks)batch import
enhancementhelp wanted

Description

Cf https://github.com/wit-ai/wit/issues/1389.

We have intervals for most dimensions (e.g. Time, AmountOfMoney, Quantity, Duration, Temperature...).

We could also extend support for Numeral and Ordinal: between 5 and 10, below 10, above 7 between first and third

However we need to make sure dependent dimensions behave properly: between 5 and 10 minutes over 68 degrees less than 10 gallons I'll be here in between 5-10 minutes let's meet in 5 days - 10 days

Contributor guide

Tech stack
None
Domain
backenddata
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Duckling's dimension systemFamiliarity with interval implementationsHaskell programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue requests adding interval support for Numeral and Ordinal dimensions similar to existing dimensions like Time and Quantity. Starting by examining the interval implementation in the Duckling codebase, particularly the 'Time' dimension's interval handling, would provide a template. Ensure that dependent dimensions (e.g., Duration when used with numerals) also handle intervals correctly. The linked wit issue (wit ai/wit#1389) may contain additional context.