facebook/duckling

[Portuguese Wit Understanding] Error on Datetime understanding

Open

#351 opened on Mar 19, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Haskell (4,282 stars) (737 forks)batch import
bughelp wanted

Description

-> me on WitAi Github (https://github.com/wit-ai/wit/issues/1385#event-2210802300): So, when you type "day 10 at 18:00 hours" in portuguese ("dia 10 às 18:00 horas"), the output for "wit/datetime" just ignore the day and set only the hours. But if you type "at day 10 at 18:00 hours" in portuguese ("no dia 10 às 18:00 horas") he just send the right output for "wit/datetime".

-> jtliao commented 22 hours ago: hey @rada-a-gast, wit/datetime is powered by Duckling-- can you open a Github issue here instead, so we can get the right person to help you out?

Contributor guide

Tech stack
None
Domain
localizationmachine learning
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Portuguese languageDuckling datetime rules
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Portuguese datetime rules in Duckling, likely in the file 'Duckling/Time/PT/Brazil.clj' or similar. The issue describes that the rule misses the day when the phrase does not include 'no' before 'dia'. Compare the successful and failing cases to identify the missing pattern in the grammar. Check existing tests for Portuguese datetime to ensure the fix covers both cases.