facebook/duckling

"before the end of the month" incorrectly parsed

Open

#275 opened on Nov 1, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Haskell (4,282 stars) (737 forks)batch import
bughelp wanted

Description

Currently a phrase like "before the end of the month" gives an interval as expected, but the end date is not the last day of the month.

Examples:

curl -XPOST http://0.0.0.0:8000/parse --data 'locale=en_US&text=before the end of the month' 
[
    {
        "body": "before the end of the month",
        "dim": "time",
        "end": 27,
        "latent": false,
        "start": 0,
        "value": {
            "to": {
                "grain": "day",
                "value": "2018-11-21T00:00:00.000-08:00"
            },
            "type": "interval",
            "values": [
                {
                    "to": {
                        "grain": "day",
                        "value": "2018-11-21T00:00:00.000-08:00"
                    },
                    "type": "interval"
                }
            ]
        }
    }
]

curl -XPOST http://0.0.0.0:8000/parse --data 'locale=en_US&text=before end of dec'
[
    {
        "body": "before end of dec",
        "dim": "time",
        "end": 17,
        "latent": false,
        "start": 0,
        "value": {
            "to": {
                "grain": "day",
                "value": "2018-12-21T00:00:00.000-08:00"
            },
            "type": "interval",
            "values": [
                {
                    "to": {
                        "grain": "day",
                        "value": "2018-12-21T00:00:00.000-08:00"
                    },
                    "type": "interval"
                },
                {
                    "to": {
                        "grain": "day",
                        "value": "2019-12-21T00:00:00.000-08:00"
                    },
                    "type": "interval"
                },
                {
                    "to": {
                        "grain": "day",
                        "value": "2020-12-21T00:00:00.000-08:00"
                    },
                    "type": "interval"
                }
            ]
        }
    }
]

Contributor guide

Tech stack
None
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Haskelldate parsingDuckling library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the logic for parsing 'end of month' phrases in Duckling. The issue shows that 'before the end of the month' returns a date like the 21st instead of the last day. Look at the Date module (e.g., Duckling/Time/EN/Date.hs) to find where the end date is computed. Check if there's a rule that incorrectly uses a fixed day offset. The comments may provide additional context. Consider adding a test for this case.