CKTextComponent and links again
@fabiomassimo is already working on this.
Since Apr 14, 2019.
Assessment
This issue has not been assessed yet.
Description
Hi guys.
#246 , #253 says it is possible to get link pressed by almost hacking: accessing CKTextComponentView renderer and then getting link from it.
But the fact is CKTextComponentView.h now project-level header, and now it is impossible to access it from my code.
Maybe it is time now to implement the feature "Which link was exactly pressed"?
- Dominant language
- Objective-C++
- Stars
- 5.7k
- Forks
- 574
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from facebook/componentkit
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
facebook/componentkit#979 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
facebook/componentkit#977 · 1 comment ·
-
Abandoned? Open
Difficulty 5/5 Over a week Newbie friendliness 10/100
facebook/componentkit#976 · 2 reactions ·
-
Difficulty 1/5 Under an hour Newbie friendliness 45/100
facebook/componentkit#975 ·
-
Yoga-internal.h:135:11: error: definition of implicit copy constructor for 'Values<9>' is deprecated Open
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
facebook/componentkit#974 · 3 reactions ·