Improve component appearance and disappearance events
Nobody has claimed this yet.
Assessment
This issue has not been assessed yet.
Description
Appearance/disappearance events can be inconsistent and unreliable, likely due to the fact they are typically driven by the underlying UICollectionView. We should investigate better alternatives that satisfy the following properties:
- Components that are added while a tree is onscreen should receive a
-[CKComponentController componentTreeWillAppear]event - Components that are removed while a tree is onscreen should receive a
-[CKComponentController componentTreeDidDisappear]event - There should be a guaranteed balance between both events; a
-[CKComponentController componentTreeWillAppear]event should be followed by at most one-[CKComponentController componentTreeDidDisappear]event
- Dominant language
- Objective-C++
- Stars
- 5.7k
- Forks
- 574
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from facebook/componentkit
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
facebook/componentkit#979 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
facebook/componentkit#977 · 1 comment ·
-
Abandoned? Open
Difficulty 5/5 Over a week Newbie friendliness 10/100
facebook/componentkit#976 · 2 reactions ·
-
Difficulty 1/5 Under an hour Newbie friendliness 45/100
facebook/componentkit#975 ·
-
Yoga-internal.h:135:11: error: definition of implicit copy constructor for 'Values<9>' is deprecated Open
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
facebook/componentkit#974 · 3 reactions ·