facebook/TestSlide

Validate that contexts are not async defs

Open

#143 opened on Apr 7, 2020

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Python (58 forks)auto 404
TestSlide DSLeasyenhancementgood first issuehelp wanted

Repository metrics

Stars
 (147 stars)
PR merge metrics
 (PR metrics pending)

Description

This should yield a failure:

@context
def top(context):
  @context.sub_context
  async def sub(context):
     ...

But is currently being silently ignored. Let's turn this into a failure.

Check:

  • @context
  • @context.sub_context
  • @context.shared_context

Contributor guide

Research direction
Add validation in the @context, @context.sub context, and @context.shared context decorators to reject async def functions by raising a clear error.
Tech stack
python
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80