Add light theme

Open
#71 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
sass
Domain
design, frontend

Research direction

Start by reviewing how the editor currently handles options such as font settings and where its existing theme styles are defined. Compare that structure with the linked SASS theming guide and determine the scope of a light theme alongside the current dark appearance. Done means the editor offers a usable light theme and the chosen theme approach is applied consistently.

Written by the indexing model from the issue text.

Description

@vasily-kirichenko has requested a light theme for the editor. Given that we already offer options like setting the font, it can be a nice addition to be able to set the theme and hopefully it's not too difficult.

There are several guides to do theming with SASS, this one proposes to use a value dictionary and then a theming mixing to generate multiple rules prefixed with the theme name like:

$themes: (
  light: (
    backgroundColor: #fff,
    textColor: #408bbd,
  ),
  dark: (
    backgroundColor: #222,
    textColor: #ddd,
  ),
);

// Usage

.app-container {
  @include themify($themes) {
    color: themed('textColor');  
    background-color: themed('backgroundColor');  
  }
}

What do you think @MangelMaxime? Should we apply this approach?

Dominant language
F#
Stars
68
Forks
36
Avg merge
13h 1m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fable-compiler/repl

All issues in fable-compiler/repl

Similar issues

More Design issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.