links with underscores in their names raise InvalidKeyword
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start in go.py at getList and the InvalidKeyword raise around line 591, then trace how list names are validated and how the default handler calls this path. Determine the intended underscore policy and define done as either supporting these names or returning an error that clearly explains the restriction, with coverage for the reported keyword.
Written by the indexing model from the issue text.
Description
We need to return a better error here for the user. They're not told why an underscore is wrong, nor do I really know why it's wrong. Should we allow them?
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/cherrypy/_cprequest.py", line 670, in respond
response.body = self.handler()
File "/usr/local/lib/python2.7/site-packages/cherrypy/lib/encoding.py", line 217, in __call__
self.body = self.oldhandler(*args, **kwargs)
File "/usr/local/lib/python2.7/site-packages/cherrypy/_cpdispatch.py", line 61, in __call__
return self.callable(*self.args, **self.kwargs)
File "./go.py", line 757, in default
ll = g_db.getList(keyword, create=False)
File "/home/lab/tools/general/f5go/go.py", line 591, in getList
raise InvalidKeyword("keyword '%s' not sanitary" % listname)
InvalidKeyword: keyword 'with_underscores' not sanitary
- Dominant language
- Python
- Stars
- 22
- Forks
- 10
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from f5devcentral/f5go
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
f5devcentral/f5go#22 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
f5devcentral/f5go#12 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
f5devcentral/f5go#8 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
f5devcentral/f5go#2 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
f5devcentral/f5go#1 ·
All issues in f5devcentral/f5go
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100