Node names should be allowed to contain the `%` character

Open
#29 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ruby

Research direction

Start by locating the F5_node name validation that rejects values matching /Partition/name and compare it with the BIG-IP behavior described in the issue. Done means node names containing %, including route-domain names such as /dev-k8s/10.2.0.77%0, are accepted without producing the reported evaluation error.

Written by the indexing model from the issue text.

Description

enhancement

The puppet module fails with errors like this:

Error: /Stage[main]/Profiles::Networking::F5::Global_pools/F5_pool[/Common/pup_rp-pool]: Could not evaluate: Parameter name failed on F5_node[/dev-k8s/10.2.0.77%0]: name must match the pattern /Partition/name

These errors show up even when the node is not being managed by this module. Our particular use case is more documented here: https://github.com/F5Networks/k8s-bigip-ctlr/issues/632

Clearly % should be allowed in node names since creating an arbitrary node with create ltm node <ipaddress> will create a node with the name <ipaddress%<route domain> by default.

Dominant language
Ruby
Stars
13
Forks
24
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from f5devcentral/f5-puppet

All issues in f5devcentral/f5-puppet

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.