eza-community/eza

feat: better quotations around filenames with space

Open

#728 opened on Dec 15, 2023

View on GitHub
 (3 comments) (2 reactions) (0 assignees)Rust (21,783 stars) (439 forks)batch import
good first issueoutput

Description

Hello,

reposting here my suggestions from #318 :

I think the different color for eza quotes from @ariasuni is a great idea, cause as it is it's hard to see at a glance that it was added by eza and not part of the name. Maybe using the same color but more pale or darker? Since it's mostly a technicality it does not need to be as visible as the rest.

Also is it possible to have the same type of quotes for all? For instance if a folder uses single quotes in its filename eza will add double quote for that folder but will still use single quotes for the rest, it's kind of messy.

Quotes also break alignment I'd say, is it possible to add a spacing to those that don't need quotes, or maybe someone has a better idea for that? Adding quotes to all? Not sure.

Thank you!

Contributor guide

Tech stack
rust
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic Rustterminal output formatting concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Start by exploring the quote handling logic in the output formatting code, likely in files related to color and style. Refer to the previous issue #318 for context. Consider implementing consistent quote types (single or double) and adding spacing for files without quotes to maintain alignment. Test with filenames containing spaces and special characters.