expressjs/multer

Filesize in mutliple upload returns fieldname instead of filename

Open

#607 opened on Jun 27, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (11,136 stars) (1,043 forks)batch import
enhancementhelp wanted

Description

that is worth when you want to upload multiple files and one file is above filesize limitation. you´re not able to inform user about that rejected file... https://github.com/expressjs/multer/blob/master/lib/make-middleware.js#L141 pls, change fieldname to filename, or even better with the file object

Contributor guide

Tech stack
javascriptnodejsexpress
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptNode.jsmulter basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the code in lib/make middleware.js around line 141. Understand the context of the error callback when file size limit is exceeded. The issue suggests replacing `fieldname` with `filename` or providing the file object. Check the current implementation and ensure the change aligns with the expected behavior for multiple file uploads. Consider looking at related tests or comments in the issue for additional context.