expo/ex-navigation

Flow errors

Open

#87 opened on Sep 14, 2016

View on GitHub
 (7 comments) (1 reaction) (0 assignees)JavaScript (1,002 stars) (207 forks)batch import
help wanted

Description

I have Flow version 0.32.0 and ex-navigation version 1.5.26. When I run flow in my project root I got this:

node_modules/@exponent/ex-navigation/src/ExNavigationAlertBar.js:153
153:     this._textContainerRef.measure((l, t, w, height) => {
         ^ call of method `measure`. Function cannot be called on
153:     this._textContainerRef.measure((l, t, w, height) => {
         ^ property `measure` of unknown type

node_modules/@exponent/ex-navigation/src/ExNavigationStack.js:435
435:         <AlertBarComponent
             ^ React element `AlertBarComponent`
435:         <AlertBarComponent
             ^ React element `AlertBarComponent`. Expected React component instead of
431:     const AlertBarComponent = this.props.alertBarComponent || this.context.alertBarComponent || ExNavigationAlertBar;
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ mixed

node_modules/@exponent/ex-navigation/src/ExNavigationStack.js:435
435:         <AlertBarComponent
             ^ React element `AlertBarComponent`
435:         <AlertBarComponent
             ^ React element `AlertBarComponent`. Expected React component instead of
431:     const AlertBarComponent = this.props.alertBarComponent || this.context.alertBarComponent || ExNavigationAlertBar;
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ property `alertBarComponent` of unknown type

node_modules/@exponent/ex-navigation/src/ExNavigationStack.js:472
472:       <HeaderComponent
           ^ React element `HeaderComponent`
472:       <HeaderComponent
           ^ React element `HeaderComponent`. Expected React component instead of
464:     const HeaderComponent = this.props.headerComponent || this.context.headerComponent || NavigationBar;
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ mixed

node_modules/@exponent/ex-navigation/src/ExNavigationStack.js:472
472:       <HeaderComponent
           ^ React element `HeaderComponent`
472:       <HeaderComponent
           ^ React element `HeaderComponent`. Expected React component instead of
464:     const HeaderComponent = this.props.headerComponent || this.context.headerComponent || NavigationBar;
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ property `headerComponent` of unknown type

node_modules/@exponent/ex-navigation/src/drawer/ExNavigationDrawer.js:165
165:         {items.map(item => this.renderItemContent(item))}
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call of method `map`
165:         {items.map(item => this.renderItemContent(item))}
                                                       ^^^^ undefined. This type is incompatible with
170:   renderItemContent(drawerItem: Object) {
                                     ^^^^^^ object type

node_modules/@exponent/ex-navigation/src/drawer/ExNavigationDrawerLayout.js:78
 78:     return this.props.items.map((item, index) => {
                ^ call of method `map`. Method cannot be called on
 78:     return this.props.items.map((item, index) => {
                ^^^^^^^^^^^^^^^^ property `items` of unknown type

node_modules/@exponent/ex-navigation/src/sliding-tab/ExNavigationSlidingTab.js:198
198:     return tabItem && tabItem.renderLabel ? tabItem.renderLabel(options) : null;
                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call of method `renderLabel`. Function cannot be called on
198:     return tabItem && tabItem.renderLabel ? tabItem.renderLabel(options) : null;
                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ property `renderLabel` of unknown type

node_modules/@exponent/ex-navigation/src/tab/ExNavigationTab.js:171
171:         {tabs.map(tab => this.renderTab(tab))}
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call of method `map`
171:         {tabs.map(tab => this.renderTab(tab))}
                                             ^^^ undefined. This type is incompatible with
176:   renderTab(tabItem: Object) {
                          ^^^^^^ object type


Found 9 errors

Am I missing some configurations or what is the problem?

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Flow basicsReact Native
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue reports Flow errors in multiple files of the ex navigation library, specifically in ExNavigationAlertBar.js, ExNavigationStack.js, ExNavigationDrawer.js, etc. The errors indicate that Flow cannot infer types for component props like alertBarComponent and headerComponent, and missing type annotations for methods. A potential fix could involve adding proper Flow type definitions for these component props. However, the issue is old and the library might have been updated. Investigate the current state of the repository, check if similar issues have been fixed, and consider if an upgrade to a newer Flow version resolves the problem.