expo/ex-navigation

Dont apply scale on floatVertical

Open

#37 opened on Aug 16, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (207 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,002 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

as discussed on exponent slack with @brentvatne, we shouldn't do scale on floatVertical. That's any the default animation anyway atleast on ios.

Refer the thread here: https://exponentjs.slack.com/files/naveenkonduru/F2190U1J8/pasted_image_at_2016_08_14_05_52_pm.png

Contributor guide

Research direction
Examine the floatVertical animation implementation in the codebase and remove any scale transformation applied during the animation.
Tech stack
javascript
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitReact Native
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80