expo/ex-navigation

Dont apply scale on floatVertical

Open

#37 opened on Aug 16, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,002 stars) (207 forks)batch import
enhancementhelp wanted

Description

as discussed on exponent slack with @brentvatne, we shouldn't do scale on floatVertical. That's any the default animation anyway atleast on ios.

Refer the thread here: https://exponentjs.slack.com/files/naveenkonduru/F2190U1J8/pasted_image_at_2016_08_14_05_52_pm.png

Contributor guide

Tech stack
react nativejavascript
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
First, locate the file that defines the floatVertical transition animation, typically in a transitions directory or within navigation configuration. Look for a scale property being applied to the floatVertical transition and remove or disable it. The Slack thread mentioned may provide additional context, but is not publicly accessible. The change is minimal and localized.