`e2e/tests/utils/openApp.js` too specific
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- mobile-dev, testing-qa
Research direction
Start by reading e2e/tests/utils/openApp.js, especially resolveConfig and the configurationName check. Verify the behavior with configuration names such as ios.sim.debug and other intermediate naming formats; the work is done when debug configurations consistently use the debug app path without changing non-debug launches.
Written by the indexing model from the issue text.
Description
The openApp.js utility file is a great work around for local development; however, when bootstrapping / setting up Detox, the detoxrc.js file can refer to a config format such as ios.sim.debug or some other intermediate nomenclature between & .
As such, the conditional designed to check for a debug environment, only passes if it is the 2nd element of a "." split array.
I propose checking to see if the configuration name contains the word "debug" instead.
module.exports.openApp = async function openApp() {
const config = await resolveConfig();
if (config.configurationName.split(".").includes("debug")) {
return await openAppForDebugBuild(platform);
} else {
return await device.launchApp({
newInstance: true,
});
}
};
- Dominant language
- Java
- Stars
- 34
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from expo/eas-tests-example
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
expo/eas-tests-example#7 · 12 comments ·
All issues in expo/eas-tests-example
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
oracle/javavscode#652 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
OpenAPITools/openapi-generator#25014 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
AloisSeckar/demos-java#380 ·