German adjectives ending on `-e` are not lemmatized using the lookup lemmatizer
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start with spacy-lookups-data/spacy_lookups_data/data/de_lemma_lookup.json and reproduce the two German adjective examples from the issue. Check the lookup entries for adjective forms ending in -e and compare their capitalization and lemma values; done means forms such as “schöne” produce the expected lowercase lemma consistently.
Written by the indexing model from the issue text.
Description
How to reproduce the behaviour
import spacy
nlp = spacy.load('de')
s1 = 'Der schöne Garten'
doc = nlp(s1)
[(t, t.lemma_) for t in doc]
>> [(Der, 'der'), (schöne, 'schöne'), (Garten, 'Garten')]
s2 = 'Ein schöner Garten'
doc = nlp(s2)
[(t, t.lemma_) for t in doc]
>> [(Ein, 'Ein'), (schöner, 'schön'), (Garten, 'Garten')]
My Environment
- spaCy version: 2.2.2
- Platform: Linux-5.0.0-25-generic-x86_64-with-LinuxMint-19.2-tina
- Python version: 3.6.7
- Models: de
Reason
As far as I can see, all forms of German adjectives ending on e in spacy-lookups-data/spacy_lookups_data/data/de_lemma_lookup.json are capitalized, e.g.:
"Dekorative": "dekorativ",
"Weiße": "Weiß",
"Schöne": "Schönes",
- Dominant language
- Python
- Stars
- 33.9k
- Forks
- 4.7k
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from explosion/spaCy
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100