evollu/react-native-fcm

Does react-native-fcm support RemoteViews?

Open

#780 opened on Feb 8, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (1,733 stars) (688 forks)batch import
help wanted

Description

Hi Libin Lu / evollu. Thanks for creating this library. 😄

I am trying to build something like this.

How do you suggest that I do it? I thought of using RemoteViews XML templates (that reside in the consumer's code base / repository and outside /node_modules) inside react-native-fcm (that resides inside /node_modules) to extend/override SendNotificationTask to create a custom notification layout. Would like your inputs on this.

Contributor guide

Tech stack
react nativejavaandroid
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
Android developmentRemoteViews API knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate how react native fcm currently builds notifications in SendNotificationTask.java (https://github.com/evollu/react native fcm/blob/master/android/src/main/java/com/evollu/react/fcm/SendNotificationTask.java). Determine if RemoteViews can be passed as a parameter or if the notification builder needs to be extended. Check existing comments for any suggestions from maintainers. Consider that RemoteViews require a custom layout XML, which would need to be accessible from the consumer app's resources.