evanw/node-source-map-support

Support absolute file:// paths in sourceMappingURL

Open

#133 opened on Apr 27, 2016

View on GitHub
 (6 comments) (2 reactions) (0 assignees)JavaScript (242 forks)batch import
help wanted

Repository metrics

Stars
 (2,078 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi! I'm working on https://github.com/mozilla/tofino and we have some interesting requirements. It appears that we need absolute file:// paths in our sourceMappingURL to support source maps in the (Chrome) devtools that Electron provides natively. That is, we want:

//# sourceMappingURL=file:///Users/nalexander/Mozilla/tofino/lib/main/browser.map

Unfortunately, that conflicts with source-map-support, which doesn't appreciate absolute paths of this kind. Would you merge a patch to handle (in Node.js only) file:// protocols?

Contributor guide

Research direction
Look at the current source map support source code to understand how sourceMappingURL is parsed. Add logic to detect file:// absolute paths and handle them correctly in Node.js by converting them to filesystem paths.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70