evanmoran/oj

Inserting oj css at runtime only works the first time

Open

#22 opened on Jan 3, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (449 stars) (7 forks)batch import
BugHelp Wanted

Description

Should be a simple fix, but requires a global OJ cache (should be little overhead) so changes to css at runtime can override previous changes!

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript basicsDOM manipulationCaching patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the codebase, likely in the main oj source file (e.g., oj.js), to find where CSS strings are inserted into the DOM at runtime. Currently, inserting CSS only works the first time because there is no mechanism to track and update previously inserted CSS. The fix should implement a global cache (e.g., a Map) that stores references to style elements or CSS rules, and on subsequent calls, remove or update the previous insertion. This will require understanding the current insertion method and ensuring the cache is properly cleared when overriding CSS changes.
Inserting oj css at runtime only works the first time · evanmoran/oj#22 | Good First Issue