eugenkiss/chanobol

Remaining WebM Issues

Open

#185 opened on Apr 3, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (11 forks)github user discovery
enhancementhelp wantedhigh-impactusability

Repository metrics

Stars
 (52 stars)
PR merge metrics
 (PR metrics pending)

Description

  • Where are the downloaded files actually saved by fenster? Is there a limited cache or will all the available storage space simply be filled? The latter wouldn't be ideal. In general, I should take a more principled approach to caching because right now Ion takes care of it but I don't even know it's storage filling strategy...
  • For consistency with images and gifs, webms should be scalable, pinchable and pannable. In particular, pinching to close should be supported. Due to using fenster which draws the video on a TextureView this should be possible in principle. The gestureDetector that is already there in MediaView can be used to implement this logic.
  • An ongoing network webm loading request should be cancelled once the user swipes to another side in MediaActivity resp. MediaView (is this already done implicitly due to the videoView.suspend?).
  • When playing a webm and resuming to Chanobol from another application the area where the webm was playing is black. Tapping on it and clicking on play resumes the playback to a normal state.
  • If the video fits the screen (almost) exactly, then (at least on lollipop) the navigation bar is on top of the video controls. I see a way to fix this but it is not high-priority for me personally.
  • Auto-Playing WebM (when In-app webm playing is activated) should me more configurable. E.g. 'auto-play like gif', always auto-play', 'auto-play on wlan', 'never auto-play'. The exception to all of these options should be that when clicking on a webm directly in the gallery or in a post card this one should auto-play immediately in the opened MediaActivity but if you swipe to another MediaView than that one will only auto-play depending on the chosen setting. 'auto-play like gif' means that it should even start playing in a postcard.
  • Sometimes thumbnail sticks out above and under video.
  • On Genymotion HTC Evo 4.1.1 emulator the video controls don't show up. It's just a black-half-transparent background with a progress bar (spinner)...
  • From a reviewer: "I can load WEBMs on my browser and other 4chan programs perfectly fine. It's just this program. I'll keep trying. My device is Kyocera Duraforce E6560 ATT if you were wondering. It has a quad core so I would think it's capable."
  • From a reviewer: "webms are stuck buffering if I try to play then using the app rather than externally." HTC One (m7)
  • From a reviewer: "WebMs with sound actually play sound, but the video remains static with the buffering circle being the only thing in motion" App version 1.3.19 HTC One (m7)
  • Maybe Google's explayer (used by Youtube) or ITEC Mediaplayer could be used in the future as it seems that fenster is not under active development anymore and does not seem to be in a finished state (although it works undeniably better than the native VideoView for my devices). Also, some webms are just not played correctly and maybe a switch to exoplayer or something similar could improve this.

Contributor guide