eugenkiss/chanobol

Improve Post Card Image Scaling Approach (Cut-off)

Open

#176 opened on Mar 29, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (11 forks)github user discovery
beginner-friendlyenhancementhelp wantedhigh-impact

Repository metrics

Stars
 (52 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

See PostView.calcScaleType (ore something like that). In principle, it could be possible that there are cases where there are thin color borders on the sides. When they are very thin change the scale type.

From a reviewer:

I haven't noticed any issues other than the edges on larger images tend to be cut off a tiny bit. I compared the same images to the ones on chanu and the latter didn't seem to have that issue although I'm not sure why.

Yes, the determineScaleType method in PostView is really crude at the moment. I think the problem is, that I do not take into account the horizontal padding of the post card. In any case, it might be worthwhile to study Chanu's solution so that images are never cut off (not even a tiny bit).

Contributor guide

Research direction
Inspect the PostView.calcScaleType method and study Chanu's solution to avoid image cut off, considering horizontal padding.
Tech stack
javaandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaAndroid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60