eugenkiss/chanobol

List View as Alternative to Grid View on ThreadsActivity/BoardsActivity/FavoritesActivity

Open

#126 opened on Mar 3, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (11 forks)github user discovery
beginner-friendlyenhancementhelp wantedhigh-impact

Repository metrics

Stars
 (52 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Request from a review:

The only gripes I have is that there is no option to remove grid view on the boards

Review request:

Grid view to see the catalog is annoying because you see so little text, so I recomended looking at the catalog in your browser.

This is relatively straightforward although not exactly a small task. The settings pane/activity needs a checkbox or something to switch between grid and list view for a board, favorites etc. A new view_thread_list.xml (analogous view_board_list.xml) should be created (and the respective PostListEntryView.java or something) and depending on the setting either view_thread or view_thread_list is inflated in the respective adapter. Depending on the setting a LinearLayout or possible the same Gridlayout with column count 1 must be used. Maybe an abstract PostView class should be created with children TilePostView and ListEntryPostView. Since the non-tile view can show more information this should be exploited.

Don't forget to check in onResume if the setting has been changed to possibly update the layout (or cheap solution would be to need a restart which would be okay if activity backstack could be recreated).

Contributor guide

Research direction
Examine the existing grid view layout and adapter implementations for threads and boards. Create a new list view layout (e.g., view thread list.xml) and a corresponding view holder. Add a setting toggle in the preferences to switch between grid and list mode. Modify the adapters to inflate the appropriate layout based on the setting. Update onResume to check for setting changes and refresh the view.
Tech stack
java
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android developmentJavaXML layouts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60