eugenkiss/chanobol

Swiping When Zoomed Into Image

Open

#125 opened on Mar 2, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (11 forks)github user discovery
help wantedusability

Repository metrics

Stars
 (52 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The ViewPager gesture detection doesn't mix well with the scroll gesture detection of PhotoView. That's why I disabled swiping when you're zoomed into an image. But in principal swiping should be allowed for a zoomed in image on the condition that swiping only starts if you've scrolled to the right or left edge of the image. It might be possible to hack something together by unlocking HackyViewPager when you're at an edge or play with the gesture listeners resp. onTouch/dispatchTouchEvent stuff (see http://developer.android.com/training/gestures/index.html)...

Contributor guide

Research direction
Look into how PhotoView and ViewPager handle touch events and determine a way to allow swiping only when at the edge of the image. Consider implementing a custom ViewPager that delegates swiping based on scroll position.
Tech stack
javaandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
AndroidJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50