ethereum/mist

Use electron builder NSIS installer

Open

#4,037 opened on Jul 30, 2018

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (7,425 stars) (2,263 forks)batch import
Module: Build processOS: Windowshelp wanted

Description

Currently, our build process takes care of building NSIS (windows installer) on its own. We should migrate it to electron-builder way, to simplify our process and take advantage of electron-builder code signing functionality (#3444).

  • add NSIS target to the list
  • port this nsi script to the new solution
  • remove build-nsis from gulp tasks.

Where to begin: Looking at gulpFile.js and w

Related code:

Contributor guide

Tech stack
javascriptelectron
Domain
desktoprelease
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
electron builder basicsgulp task understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Review gulpfile.js (line 85) and gulpTasks/building.js (lines 144, 282-295) to understand current NSIS handling. Examine windows installer.nsi script to be ported. Add NSIS target to electron builder config, port the script, and remove build nsis gulp tasks. Note that the repository is deprecated; verify with maintainers if the change is still desired.
Use electron builder NSIS installer · ethereum/mist#4037 | Good First Issue