ethereum/mist

Use electron builder NSIS installer

Open

#4,037 opened on Jul 30, 2018

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (2,263 forks)batch import
Module: Build processOS: Windowshelp wanted

Repository metrics

Stars
 (7,425 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently, our build process takes care of building NSIS (windows installer) on its own. We should migrate it to electron-builder way, to simplify our process and take advantage of electron-builder code signing functionality (#3444).

  • add NSIS target to the list
  • port this nsi script to the new solution
  • remove build-nsis from gulp tasks.

Where to begin: Looking at gulpFile.js and w

Related code:

Contributor guide

Research direction
Investigate how to use electron builder to create NSIS installer by examining electron builder documentation and the existing NSIS script. Replace the current gulp build steps with electron builder configuration.
Tech stack
javascriptnodejs
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60