ethereum/go-ethereum

Geth should handle genesis block with default syncmode

Open

#28,222 opened on Sep 28, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (51,042 stars) (21,913 forks)batch import
help wantedtype:bug

Description

System information

Geth version: v1.13.2

Expected behaviour

When running without specifying --syncmode=full (i.e. the default i.e. snap sync) geth should transition to full sync automatically for pre-genesis / genesis blocks.

Actual behaviour

Geth doesn't import the 1st block:

Ignoring payload while snap syncing number=1

Steps to reproduce the behaviour

Run geth without --syncmode=full on a new network

Contributor guide

Tech stack
go
Domain
backendinfrastructure
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the sync mode logic in go ethereum, specifically how the default snap sync handles the genesis block. Look at the `eth/downloader` and `eth/sync` packages to understand the transition from snap to full sync. Check if there is a condition that prevents importing the first block when snap sync is active, and identify the required changes to auto detect genesis block and switch to full sync.
Geth should handle genesis block with default syncmode · ethereum/go-ethereum#28222 | Good First Issue