ethereum/casper

Deploy PURITY_CHECKER and MSG_HASHER with via compile in testing

Open

#159 opened on May 30, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (685 stars) (184 forks)batch import
blockedgood first issue

Description

Issue

PURITY_CHECKER and MSG_HASHER are currently deployed via previously sign txs in the testing framework. This is super opaque and makes it tough to test any changes to purity checker. It is also not how we plan on deploying in the EIP

Proposed implementation

  • ensure msg_hasher and purity_checker source are in the repo
  • compile and deploy dynamically in testing rather than sending a previously sign tx

BLOCKER: #69 and #73. Both of these issues port msg_hasher and purity_checker to vyper LLL so we don't have to introduce serpent as a dependency.

Contributor guide

Tech stack
python
Domain
testing
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Port msg hasher to Vyper LLL (#69)Port purity checker to Vyper LLL (#73)
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
First, ensure that issues #69 and #73 are completed to port msg hasher and purity checker to Vyper LLL. Then, modify the testing framework to dynamically compile and deploy these contracts instead of using pre signed transactions. Look at the current testing setup in the repository's test files to understand the existing deployment method.