ethereum-optimism/superchain-ops

Automatically check the domain and message hashes sent to Ledger matches the ones in the simulation

Open

#195 opened on May 10, 2024

View on GitHubContributor guide
 (3 comments) (0 reactions) (2 assignees)Solidity (127 forks)github user discovery
good first issue

Repository metrics

Stars
 (98 stars)
PR merge metrics
 (Avg merge 2d 4h) (16 merged PRs in 30d)

Description

Recently, due to a bug fixed in https://github.com/base-org/contract-deployments/pull/166/files, we were getting different hashes sent to the ledger devices compared to the ones in the Tenderly simulation. It would be great if we can detect this by automatically checking the domain and message hashes sent to Ledger matches the ones in the simulation. This may require us to migrate away from Tenderly to a more programmatically parsable one.

See https://www.notion.so/oplabs/PM-48-Wrong-message-hash-sent-to-Signers-Ledger-during-an-L2-contract-upgrade-c893131d9daa440bad6fe09c848db54d for the original postmortem

Contributor guide

Research direction
Investigate how to programmatically extract domain and message hashes from Tenderly simulations and compare with those sent to Ledger devices.
Tech stack
None
Domain
blockchainsecurity
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30