etcd-io/etcd

[test] support cluster-api style rolling replacement upgrade

Open

#20,804 opened on Oct 15, 2025

View on GitHub
 (10 comments) (0 reactions) (2 assignees)Go (10,352 forks)batch import
area/testinghelp wantedstage/trackedtype/feature

Repository metrics

Stars
 (51,701 stars)
PR merge metrics
 (Avg merge 6d 3h) (71 merged PRs in 30d)

Description

What would you like to be added?

Currently our e2e framework supports in-place upgrade. We just replace the binary, and reuse the existing data.

https://github.com/etcd-io/etcd/blob/30452ab110473eda5f60bdb301c046194a154e91/tests/framework/e2e/downgrade.go#L131

However, the cluster-api/Kubeadm upgrades Kubernetes cluster in a rolling replacement approach,

  • add a new learner first;
  • promote it later
  • remove an old node
  • repeat the above steps until all nodes are replaced.

The key difference is the new member(learner) gets started without local data, so it may receive a snapshot from the leader.

We should update our e2e test framework to support both upgrade approaches,

  • rolling in-place upgrade
  • rolling replacement upgrade

Why is this needed?

To improve test coverage.

Contributor guide

Research direction
Study the current e2e upgrade test implementation and design a new rolling replacement upgrade strategy. Focus on adding learner promotion and node removal steps.
Tech stack
go
Domain
backendtestinginfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gogit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55