etcd-io/etcd

Reduce the time e2e tests take

Open

#18983 opened on Dec 2, 2024

View on GitHub
 (34 comments) (0 reactions) (1 assignee)Go (51,701 stars) (10,352 forks)batch import
area/testinghelp wantedtype/feature

Description

What would you like to be added?

E2e tests are taking over 40 minutes now, we should keep them unver 30 minutes or even lower.

For the top test candidates to optimize use https://testgrid.k8s.io/sig-etcd-periodics#ci-etcd-e2e-amd64&graph-metrics=test-duration-minutes

Current state

  • go.etcd.io/etcd/tests/v3/common.TestMemberAdd > 5 minutes
  • go.etcd.io/etcd/tests/v3/common.TestMemberRemove > 2 minutes
  • go.etcd.io/etcd/tests/v3/e2e.TestAuthority > 1.5 minutes
  • go.etcd.io/etcd/tests/v3/e2e.TestRuntimeReconfigGrowClusterSize > 1 minute
  • go.etcd.io/etcd/tests/v3/common.TestUserAdd_Simple > 1 minute
  • go.etcd.io/etcd/tests/v3/common.TestLeaseGrantAndList ~ 50 seconds
  • go.etcd.io/etcd/tests/v3/e2e.TestVerifyHashKVAfterCompact ~50 seconds
  • go.etcd.io/etcd/tests/v3/e2e.TestMixVersionsSnapshotByMockingPartition ~ 40 seconds
  • go.etcd.io/etcd/tests/v3/common.TestKVDelete ~ 40 seconds
  • go.etcd.io/etcd/tests/v3/common.TestLeaseGrantTimeToLiveExpired ~ 35 seconds
  • go.etcd.io/etcd/tests/v3/e2e.TestWatchDelayForManualProgressNotification ~ 35 seconds ...

Looking for someone to take a look at the top tests and propose improvements to reduce runtime

image

Why is this needed?

We should keep the test execution time low to ensure good contributor expirience.

Contributor guide

Tech stack
go
Domain
testingperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Goe2e testingetcd codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the top slow tests listed in the issue, particularly TestMemberAdd (over 5 minutes) and TestMemberRemove (over 2 minutes). Investigate why these tests are slow by looking at the test code in the tests/v3/common and tests/v3/e2e directories. Propose optimizations such as reducing setup overhead, parallelizing test steps, or using lighter test fixtures. The issue comments may contain hints; check https://testgrid.k8s.io/sig etcd periodics for historical duration graphs.