etcd-io/etcd

Introduce more failpoints into etcd watch

Open

#18,681 opened on Oct 5, 2024

View on GitHub
 (16 comments) (0 reactions) (1 assignee)Go (10,352 forks)batch import
area/robustness-testingarea/testinghelp wanted

Repository metrics

Stars
 (51,701 stars)
PR merge metrics
 (Avg merge 6d 3h) (71 merged PRs in 30d)

Description

What would you like to be added?

Spin-off from https://github.com/etcd-io/etcd/issues/17529

Similar to https://github.com/etcd-io/etcd/pull/17680/files we should add more failpoints into watch and simulate:

  • slow watch sync
  • slow watch resynchronization
  • slow watch progress notify

etc

Why is this needed?

Prevent and detect other issues like https://github.com/etcd-io/etcd/issues/17529

Contributor guide

Research direction
Study the existing failpoint implementation in the etcd repository, particularly PR #17680. Then identify the watch code paths for sync, resynchronization, and progress notify, and add similar failpoint logic to simulate slow operations.
Tech stack
go
Domain
backendtesting
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40