esnet/iperf

Possible compile on Solaris 10

Closed

#964 opened on Feb 27, 2020

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C (1,083 forks)batch import
Help Wantedenhancementportability

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 18d 1h) (4 merged PRs in 30d)

Description

EDIT: Reformatted code for legibility. --bmah

Context

  • Version of iperf3: 3.7

  • Hardware: Sparc

  • Operating system (and distribution, if any):

Solaris 10

  • Other relevant information (for example, non-default compilers, libraries, cross-compiling, etc.):

gcc

  • Possible Solution

Not being used with pull request I submit here some code that seems to fix something under Solaris 10: Add the follwing in iperf_auth.c found this on https://github.com/firnsy/barnyard2/issues/98

#if defined(__sun)
/* Written by Kaveh R. Ghazi <ghazi@caip.rutgers.edu> */
char *
strndup (const char *s, size_t n)
{
  char *result;
  size_t len = strlen (s);

  if (n < len)
    len = n;

  result = (char *) malloc (len + 1);
  if (!result)
    return 0;

  memcpy (result, s, len);
  result[len] = '\0';
  return(result);
}
#endif

Contributor guide

Research direction
The issue requires adding a `strndup` implementation in `iperf auth.c` for Solaris 10 compatibility. The provided code snippet can be used directly, but verify that it compiles with GCC on Solaris and does not affect other platforms. Check for any existing conditional compilation for Solaris in the codebase. The reference to another project's issue may offer insights.
Tech stack
c
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C programmingSolaris environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75